Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 validation #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mildabre
Copy link

@mildabre mildabre commented Dec 3, 2024

The IPv6 becomes more and more popular and should be supported in all corresponding parts of Nette Framework. Suggested php function filter_var($ip, FILTER_VALIDATE_IP) validates perfectly both IPv4 and IPv6

  • no BC break

@dg
Copy link
Member

dg commented Dec 3, 2024

Miloši, nejsem úplně šťastný z toho, že tu vytváříš, zavíráš a pak opakovaně vytváříš PR. Ty staré totiž nejdou smazat zhoršuje se hledání a tak. Pokud chceš přepsat kód, použij force push, ale prosím nevytvářej nové PR

@mildabre
Copy link
Author

mildabre commented Dec 3, 2024

@dg to se omlouvám a už si dám pozor, chtěl jsem to právě udělat tak, aby v historii nic nezůstalo, ale nepovedlo se :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants